Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
UI improvements with global search tool #1039
Makes a number of improvements to the global search tool:
I want to add one more thing into this PR before I'm satisfied with it, and that is highlighting the portions of each result that are being matched by the fuzzy search. This was present with twitter-typeahead, but requires some additional work with react-typeahead.
Here's a screenshot of the new UI, not much has changed.
In keybinding world, you should be able to just hit enter without hitting the down arrow first if the first option is what you want.
Also, if you hit escape before finishing a search, it doesn't reset the search box when you bring it back up. I'm not sure if this is an improvement or not, it depends on the particular workflow of whoever is using it.
In a later PR, we can make tab move down the list, but that isn't supported by react-typeahead yet, so it will take another PR there.