don't set shell if arguments list is empty, ability to override shell #1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With the new changes to the
ON_DEMAND
ui we made, we are defaulting the arguments list to set, but empty. Because it was now present, this triggered theshell: false
being set on the mesos task, so commands set as long strings were coming back withFailed to exec: No such file or directory
errors. This fixes that bug, and also allows us to override the shell setting in case we need to./fixes #1047