don't set shell if arguments list is empty, ability to override shell

[ssalinas]

With the new changes to the ON_DEMAND ui we made, we are defaulting the arguments list to set, but empty. Because it was now present, this triggered the shell: false being set on the mesos task, so commands set as long strings were coming back with Failed to exec: No such file or directory errors. This fixes that bug, and also allows us to override the shell setting in case we need to.

/fixes #1047

[demobox]

FYI: Workaround via the API described here

[ssalinas]

Going to merge this, got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case

[demobox]

got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case

Great, thanks!

[coderfi]

Wow, I just ran into this problem on Thursday and decided to deploy my work to our Marathon instance, but this seems like this will fix the issue so I can continue the Singularity evaluation. It's like you anticipated my every need! :)