New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set shell if arguments list is empty, ability to override shell #1049

Merged
merged 1 commit into from May 20, 2016

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented May 19, 2016

With the new changes to the ON_DEMAND ui we made, we are defaulting the arguments list to set, but empty. Because it was now present, this triggered the shell: false being set on the mesos task, so commands set as long strings were coming back with Failed to exec: No such file or directory errors. This fixes that bug, and also allows us to override the shell setting in case we need to.

/fixes #1047

@ssalinas ssalinas modified the milestone: 0.7.1 May 19, 2016

@ssalinas ssalinas added the hs_staging label May 19, 2016

@ssalinas ssalinas modified the milestones: 0.7.1, 0.6.1 May 19, 2016

@demobox

This comment has been minimized.

Show comment
Hide comment
@demobox

demobox May 19, 2016

Contributor

FYI: Workaround via the API described here

Contributor

demobox commented May 19, 2016

FYI: Workaround via the API described here

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas May 20, 2016

Member

Going to merge this, got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case

Member

ssalinas commented May 20, 2016

Going to merge this, got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case

@ssalinas ssalinas merged commit 698c8f9 into master May 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the shell_setting branch May 20, 2016

@demobox

This comment has been minimized.

Show comment
Hide comment
@demobox

demobox May 20, 2016

Contributor

got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case

Great, thanks!

Contributor

demobox commented May 20, 2016

got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case

Great, thanks!

@coderfi

This comment has been minimized.

Show comment
Hide comment
@coderfi

coderfi May 23, 2016

Wow, I just ran into this problem on Thursday and decided to deploy my work to our Marathon instance, but this seems like this will fix the issue so I can continue the Singularity evaluation. It's like you anticipated my every need! :)

coderfi commented May 23, 2016

Wow, I just ran into this problem on Thursday and decided to deploy my work to our Marathon instance, but this seems like this will fix the issue so I can continue the Singularity evaluation. It's like you anticipated my every need! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment