Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updon't set shell if arguments list is empty, ability to override shell #1049
Conversation
ssalinas
modified the milestone:
0.7.1
May 19, 2016
ssalinas
added
the
hs_staging
label
May 19, 2016
ssalinas
modified the milestones:
0.7.1,
0.6.1
May 19, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
FYI: Workaround via the API described here |
ssalinas
added
hs_qa
hs_stable
labels
May 19, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ssalinas
May 20, 2016
Member
Going to merge this, got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case
|
Going to merge this, got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case |
ssalinas
merged commit 698c8f9
into
master
May 20, 2016
ssalinas
deleted the
shell_setting
branch
May 20, 2016
ssalinas
removed
hs_qa
hs_stable
hs_staging
labels
May 20, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
demobox
May 20, 2016
Contributor
got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case
Great, thanks!
Great, thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
coderfi
May 23, 2016
Wow, I just ran into this problem on Thursday and decided to deploy my work to our Marathon instance, but this seems like this will fix the issue so I can continue the Singularity evaluation. It's like you anticipated my every need! :)
coderfi
commented
May 23, 2016
|
Wow, I just ran into this problem on Thursday and decided to deploy my work to our Marathon instance, but this seems like this will fix the issue so I can continue the Singularity evaluation. It's like you anticipated my every need! :) |
ssalinas commentedMay 19, 2016
With the new changes to the
ON_DEMANDui we made, we are defaulting the arguments list to set, but empty. Because it was now present, this triggered theshell: falsebeing set on the mesos task, so commands set as long strings were coming back withFailed to exec: No such file or directoryerrors. This fixes that bug, and also allows us to override the shell setting in case we need to./fixes #1047