don't set shell if arguments list is empty, ability to override shell #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: Workaround via the API described here |
|
Going to merge this, got bot the arguments check, and cmdLineArgs check in there @demobox , as well as a way to override shell setting if you ever need to, just in case |
Great, thanks! |
|
Wow, I just ran into this problem on Thursday and decided to deploy my work to our Marathon instance, but this seems like this will fix the issue so I can continue the Singularity evaluation. It's like you anticipated my every need! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With the new changes to the
ON_DEMANDui we made, we are defaulting the arguments list to set, but empty. Because it was now present, this triggered theshell: falsebeing set on the mesos task, so commands set as long strings were coming back withFailed to exec: No such file or directoryerrors. This fixes that bug, and also allows us to override the shell setting in case we need to./fixes #1047