Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add polyfills for Object.assign and Promise #1050

Merged
merged 1 commit into from May 20, 2016
Merged

add polyfills for Object.assign and Promise #1050

merged 1 commit into from May 20, 2016

Conversation

@tpetr
Copy link
Member

@tpetr tpetr commented May 19, 2016

Adds polyfills for Object.assign() and Promise for older brosers. Longer term fix is to use Babel to add all necessary polyfills.

/cc @stevenschlansker #1046

@ssalinas ssalinas added this to the 0.7.1 milestone May 19, 2016
@tpetr
Copy link
Member Author

@tpetr tpetr commented May 19, 2016

@ssalinas we should also probably release a 0.6.1 for folks that aren't ready to update their Mesos cluster. We can square that away separately (probably via branching off the Singularity-0.6.0 tag and then cherry-picking commits in).

@ssalinas
Copy link
Member

@ssalinas ssalinas commented May 19, 2016

Yeah, sounds good. I can do the git work for that when we are ready to release

@ssalinas ssalinas modified the milestones: 0.7.1, 0.6.1 May 19, 2016
@tpetr tpetr added the hs_staging label May 19, 2016
@stevenschlansker
Copy link
Contributor

@stevenschlansker stevenschlansker commented May 19, 2016

Thanks guys, you're the best! FWIW I solved my issue locally: https://addons.palemoon.org/extensions/other/pm-promises/ but I'm sure someone else will run into this as well.

@ssalinas ssalinas added hs_qa labels May 20, 2016
@ssalinas ssalinas merged commit d4a40f2 into master May 20, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@ssalinas ssalinas deleted the es6-polyfill branch May 20, 2016
@ssalinas ssalinas removed hs_qa labels May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.