Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable max attempts for docker pull in custom executor #1051

Merged
merged 1 commit into from Jul 20, 2016

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented May 19, 2016

@jonathanwgoodwin , still need to test this out, but should do what we need

@ssalinas ssalinas force-pushed the docker_retry branch 2 times, most recently from 719d41a to 811d80a Compare May 19, 2016
@ssalinas ssalinas modified the milestone: 0.8.0 May 20, 2016
@ssalinas ssalinas added the hs_qa label Jun 6, 2016
@@ -218,6 +218,9 @@
private int dockerClientConnectionPoolSize = 5;

@JsonProperty
private int dockerPullRetries = 1;
Copy link
Contributor

@tpetr tpetr Jun 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean it will attempt once, or retry once? it might make more sense to rename this to something like maxDockerPullAttempts

Copy link
Member Author

@ssalinas ssalinas Jun 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry once, you're right that it could be confusing, I'll update the name

Copy link
Member Author

@ssalinas ssalinas Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpetr renamed

@ssalinas ssalinas changed the title try pull one extra time for a DockerRequestException configurable max attempts for docker pull in custom executor Jun 16, 2016
@ssalinas ssalinas modified the milestone: 0.8.0 Jun 16, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Jul 20, 2016

This has been working fine in stable, merging

@ssalinas ssalinas merged commit 877a0e6 into master Jul 20, 2016
2 checks passed
@ssalinas ssalinas deleted the docker_retry branch Jul 20, 2016
@ssalinas ssalinas added this to the 0.9.0 milestone Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants