configurable max attempts for docker pull in custom executor #1051

Merged
merged 1 commit into from Jul 20, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented May 19, 2016

@jonathanwgoodwin , still need to test this out, but should do what we need

@ssalinas ssalinas added the hs_staging label May 19, 2016

@ssalinas ssalinas modified the milestone: 0.8.0 May 20, 2016

@ssalinas ssalinas added the hs_qa label Jun 6, 2016

@@ -218,6 +218,9 @@
private int dockerClientConnectionPoolSize = 5;
+ @JsonProperty
+ private int dockerPullRetries = 1;

This comment has been minimized.

@tpetr

tpetr Jun 15, 2016

Member

does this mean it will attempt once, or retry once? it might make more sense to rename this to something like maxDockerPullAttempts

@tpetr

tpetr Jun 15, 2016

Member

does this mean it will attempt once, or retry once? it might make more sense to rename this to something like maxDockerPullAttempts

This comment has been minimized.

@ssalinas

ssalinas Jun 15, 2016

Member

Retry once, you're right that it could be confusing, I'll update the name

@ssalinas

ssalinas Jun 15, 2016

Member

Retry once, you're right that it could be confusing, I'll update the name

This comment has been minimized.

@ssalinas

ssalinas Jun 16, 2016

Member

@tpetr renamed

@ssalinas ssalinas changed the title from try pull one extra time for a DockerRequestException to configurable max attempts for docker pull in custom executor Jun 16, 2016

@ssalinas ssalinas modified the milestone: 0.8.0 Jun 16, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jun 17, 2016

Member

🚢

Member

tpetr commented on 499c839 Jun 17, 2016

🚢

@ssalinas ssalinas added the hs_stable label Jun 21, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 20, 2016

Member

This has been working fine in stable, merging

Member

ssalinas commented Jul 20, 2016

This has been working fine in stable, merging

@ssalinas ssalinas merged commit 877a0e6 into master Jul 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the docker_retry branch Jul 20, 2016

@ssalinas ssalinas added this to the 0.9.0 milestone Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment