set proper Content-Type and Content-Encoding for s3 uploads #1059

Merged
merged 3 commits into from Jun 6, 2016

Conversation

Projects
None yet
2 participants
@tpetr
Member

tpetr commented Jun 2, 2016

This PR makes the S3Uploader attempt to set the proper Content-Type and Content-Encoding headers for files uploaded to S3.

@tpetr tpetr added the hs_staging label Jun 2, 2016

@jhaber

This comment has been minimized.

Show comment
Hide comment
@jhaber

jhaber Jun 2, 2016

Member

This will be so awesome

Member

jhaber commented Jun 2, 2016

This will be so awesome

@tpetr tpetr changed the title from set proper Content-Encoding for s3 uploads to set proper Content-Type and Content-Encoding for s3 uploads Jun 2, 2016

@tpetr tpetr added the hs_qa label Jun 2, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jun 2, 2016

Member

This would probably be good default settings:

s3ContentHeaders:
- filenameEndsWith: .log.gz
  contentType: text/plain
  contentEncoding: gzip
- filenameEndsWith: .log
  contentType: text/plain
Member

tpetr commented Jun 2, 2016

This would probably be good default settings:

s3ContentHeaders:
- filenameEndsWith: .log.gz
  contentType: text/plain
  contentEncoding: gzip
- filenameEndsWith: .log
  contentType: text/plain

@tpetr tpetr added the hs_stable label Jun 5, 2016

@tpetr tpetr added this to the 0.8.0 milestone Jun 6, 2016

@tpetr tpetr merged commit ae49a80 into master Jun 6, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the s3-content-encoding branch Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment