Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSetup babel for ES6 and JSX transformation. #1060
Merged
Conversation
| render() { | ||
| let options = _.pluck(this.props.requests.toJSON(), 'id'); | ||
|
|
||
| globalSearchClasses = classNames({ |
tpetr
Jun 2, 2016
Member
add const globalSearchClasses here instead of the let at the top of the file
add const globalSearchClasses here instead of the let at the top of the file
SingularityUI/webpack.config.js
Outdated
| @@ -68,7 +70,7 @@ module.exports = { | |||
| } | |||
| }), | |||
| new webpack.DefinePlugin({ | |||
| 'process.env.NODE_ENV': '"production"' | |||
| 'process.env.NODE_ENV': JSON.stringify('development') | |||
tpetr
Jun 2, 2016
Member
curious, why the change here?
curious, why the change here?
wolfd
Jun 2, 2016
Author
Contributor
Oh, right. I forgot that I put this in there.
We should figure out if there's a way to override the default behavior and not do this.
Minified react (which is used when you use production) doesn't have good error messages. I wanted to see what the issue was with something, and they were being suppressed. By the time this patch gets merged I'd like to see this behavior default to production but use development if specified on the command line.
Oh, right. I forgot that I put this in there.
We should figure out if there's a way to override the default behavior and not do this.
Minified react (which is used when you use production) doesn't have good error messages. I wanted to see what the issue was with something, and they were being suppressed. By the time this patch gets merged I'd like to see this behavior default to production but use development if specified on the command line.
… be used in gulp serve and 'production' mode to be used in gulp build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The eventual goal is to have SingularityUI to be entirely a React/Babel ES6 project.
Steps taken:
Notes on how to do coffeescript -> es6 transformation:
decaffeinatenpm module does a lot of the heavy lifting, but do it one file at a timeinkeyword).defaultto the ES6 imports