make sure to remove obsolete pending requests #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssalinas for posterity, could you link to the commit where these things got switched around? |
| @@ -2984,4 +2984,18 @@ public void testQueueMultipleOneOffs() { | |||
| Assert.assertEquals(2, taskManager.getPendingTaskIds().size()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testObsoletePendingRequestsRemoved() { | |||
|
Any chance this is worth a patch release? All our masters fill their disks a couple of times a week right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If statements got switched around a bit back when I did the work for incremental deploys, we used to be removing these. No breakage caused, just annoying extra logging and some extra iterations in the scheduler.
/cc @stevenschlansker @tpetr