Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to remove obsolete pending requests #1068

Merged
merged 3 commits into from Jun 14, 2016
Merged

make sure to remove obsolete pending requests #1068

merged 3 commits into from Jun 14, 2016

Conversation

@ssalinas
Copy link
Member

ssalinas commented Jun 7, 2016

If statements got switched around a bit back when I did the work for incremental deploys, we used to be removing these. No breakage caused, just annoying extra logging and some extra iterations in the scheduler.

/cc @stevenschlansker @tpetr

ssalinas added 2 commits Jun 7, 2016
@tpetr
Copy link
Member

tpetr commented Jun 7, 2016

@ssalinas for posterity, could you link to the commit where these things got switched around?

@@ -2984,4 +2984,18 @@ public void testQueueMultipleOneOffs() {
Assert.assertEquals(2, taskManager.getPendingTaskIds().size());
}

@Test
public void testObsoletePendingRequestsRemoved() {

This comment has been minimized.

Copy link
@tpetr

tpetr Jun 7, 2016

Member

🏆

@ssalinas
Copy link
Member Author

ssalinas commented Jun 7, 2016

@ssalinas ssalinas added the hs_stable label Jun 10, 2016
@ssalinas ssalinas merged commit cdfaf39 into master Jun 14, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@ssalinas ssalinas deleted the obsolete_reqs branch Jun 14, 2016
@stevenschlansker
Copy link
Contributor

stevenschlansker commented Jun 14, 2016

Any chance this is worth a patch release? All our masters fill their disks a couple of times a week right now.

@tpetr tpetr added this to the 0.8.0 milestone Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.