Build the UI as its own module #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +50,8 @@ var WebpackDevServer = require('webpack-dev-server'); | |||
| gulp.task("clean", function() { | |||
| return del([ | |||
| path.resolve(dest, 'static/**'), | |||
| path.resolve(dest, 'index.html')], {force: true}); | |||
| path.resolve(dest, 'index.html'), | |||
| dest], {force: true}); | |||
There was a problem hiding this comment.
i had to add {force: true} in the original implementation because we were deleting a folder outside the working directory -- this shouldnt be needed anymore
There was a problem hiding this comment.
in fact, i would further simplify this to just del([dest])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want Singularity to build independently of SingularityService. This creates a new pom for the UI and moves the build into that. SingularityService then depends on that and copies the files from
dist/to its own resources.@tpetr