New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build the UI as its own module #1073
Conversation
@@ -50,7 +50,8 @@ var WebpackDevServer = require('webpack-dev-server'); | |||
gulp.task("clean", function() { | |||
return del([ | |||
path.resolve(dest, 'static/**'), | |||
path.resolve(dest, 'index.html')], {force: true}); | |||
path.resolve(dest, 'index.html'), | |||
dest], {force: true}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had to add {force: true}
in the original implementation because we were deleting a folder outside the working directory -- this shouldnt be needed anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fact, i would further simplify this to just del([dest])
We want Singularity to build independently of SingularityService. This creates a new pom for the UI and moves the build into that. SingularityService then depends on that and copies the files from
dist/
to its own resources.@tpetr