Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add downloadUrl field, for explicitly downloading from S3 #1093

Merged
merged 2 commits into from Jun 24, 2016
Merged

Conversation

@tpetr
Copy link
Member

tpetr commented Jun 15, 2016

  • Adds an optional downloadUrl field to SingularityS3Log, which contains a signed S3 link that explicitly downloads the file (as opposed to possibly opening the file inside the browser)
  • Updates the UI such that the Download icon for an S3 file uses the downloadUrl
@tpetr tpetr added this to the 0.8.0 milestone Jun 16, 2016
@ssalinas ssalinas modified the milestone: 0.8.0 Jun 16, 2016
@tpetr tpetr added this to the 0.9.0 milestone Jun 24, 2016
@tpetr tpetr merged commit 3d6ef4a into master Jun 24, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tpetr tpetr removed hs_qa labels Jun 24, 2016
@ssalinas ssalinas deleted the s3-download-url branch Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.