New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker compose yaml to get hostname properly #1108

Merged
merged 1 commit into from Jun 22, 2016

Conversation

Projects
None yet
1 participant
@ssalinas
Member

ssalinas commented Jun 22, 2016

As mentioned in HubSpot/Singularity#1107 , for newer docker versions grabbing the hostname via InetAddress does not work when running the container in host mode. This adds a way to set the hostname via an environment variable, and will automatically find it for you when using docker-compose (i.e. DOCKER_HOST var is passed in)

@ssalinas ssalinas merged commit 7dffb17 into master Jun 22, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ssalinas ssalinas deleted the compose_hostname branch Jun 22, 2016

@ssalinas ssalinas added this to the 0.9.0 milestone Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment