Always launch docker containers in the correct parent cgroup #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the docker executor script hardcodes the parent cgroup of a docker container to "mesos/$CGROUPS_GUID". This change makes it instead discover the cgroup using "/proc/self/cgroup" per the reccommendation of: https://www.freedesktop.org/wiki/Software/systemd/PaxControlGroups/ This change also removes the code for setting memory.use_hierarchy=1 because it is ineffective. In order to set that property, it must be set on the root cgroup, before any child cgroups are created. My internal changes to cgroups on our mesos slaves takes care of that and all child cgroups inherit the property.
|
👍 I can test this further. Nitpick, but can we update the examples to be non-hubspot-specific? Other than that looks good, thanks for the cgroup expertise! |
|
@ssalinas 👍 Got rid of the reference to HubSpot in the example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the docker executor script hardcodes the parent cgroup of a docker container to
mesos/$CGROUPS_GUID. This change makes it instead discover the cgroup using/proc/self/cgroupper the reccommendation of: https://www.freedesktop.org/wiki/Software/systemd/PaxControlGroups/This change also removes the code for setting
memory.use_hierarchy=1because it is ineffective (you can see the warnings in the logs on our mesos slaves). In order to set that property, it must be set on the root cgroup, before any child cgroups are created. My internal changes to cgroups on our mesos slaves takes care of that and all child cgroups inherit the property.@ssalinas @tpetr Going to try to test this myself tonight, might need your help with the Singularity bits tomorrow. I tested that function pretty thoroughly so I expect this to just work.