Skip to content

Docker auth config#1138

Merged
ssalinas merged 5 commits into
HubSpot:masterfrom
ImagineLearning:docker-auth-config
Aug 5, 2016
Merged

Docker auth config#1138
ssalinas merged 5 commits into
HubSpot:masterfrom
ImagineLearning:docker-auth-config

Conversation

@jaredstehler

@jaredstehler jaredstehler commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

I figured the easiest way to get this done was simply to use the AuthConfig class from the spotify docker client, which has @JsonProperty annotations already; downside is they are capitalized..

  @JsonProperty("Username") private String username;
  @JsonProperty("Password") private String password;
  @JsonProperty("Email") private String email;
  @JsonProperty("ServerAddress") private String serverAddress;

also not a huge fan of the test I wrote b/c of the reflection.

Fixes #1098

@ssalinas

Copy link
Copy Markdown
Contributor

Hey @jaredstehler , sry missed this when it was first opened. Can you fix the merge conflicts and I can get this merged through our environments and into master?

@tpetr

tpetr commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

I thought I had commented already but I must have forgotten to hit Submit or something -- I'd prefer it if we used a custom POJO for these Docker auth fields (something like SingularityDockerAuthConfiguration) so that 1) we stick with a consistent naming scheme and 2) we're shielded from breaking changes from this Docker client library.

@jaredstehler

Copy link
Copy Markdown
Contributor Author

@ssalinas resolved merge conflicts
@tpetr updated to use custom pojo for docker auth config

@ssalinas ssalinas modified the milestone: 0.10.0 Jul 29, 2016
@ssalinas ssalinas merged commit d6d6e73 into HubSpot:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants