New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker auth config #1138

Merged
merged 5 commits into from Aug 5, 2016

Conversation

Projects
None yet
3 participants
@jaredstehler
Contributor

jaredstehler commented Jul 12, 2016

I figured the easiest way to get this done was simply to use the AuthConfig class from the spotify docker client, which has @JsonProperty annotations already; downside is they are capitalized..

  @JsonProperty("Username") private String username;
  @JsonProperty("Password") private String password;
  @JsonProperty("Email") private String email;
  @JsonProperty("ServerAddress") private String serverAddress;

also not a huge fan of the test I wrote b/c of the reflection.

Fixes #1098

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 21, 2016

Member

Hey @jaredstehler , sry missed this when it was first opened. Can you fix the merge conflicts and I can get this merged through our environments and into master?

Member

ssalinas commented Jul 21, 2016

Hey @jaredstehler , sry missed this when it was first opened. Can you fix the merge conflicts and I can get this merged through our environments and into master?

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jul 21, 2016

Member

I thought I had commented already but I must have forgotten to hit Submit or something -- I'd prefer it if we used a custom POJO for these Docker auth fields (something like SingularityDockerAuthConfiguration) so that 1) we stick with a consistent naming scheme and 2) we're shielded from breaking changes from this Docker client library.

Member

tpetr commented Jul 21, 2016

I thought I had commented already but I must have forgotten to hit Submit or something -- I'd prefer it if we used a custom POJO for these Docker auth fields (something like SingularityDockerAuthConfiguration) so that 1) we stick with a consistent naming scheme and 2) we're shielded from breaking changes from this Docker client library.

@jaredstehler

This comment has been minimized.

Show comment
Hide comment
@jaredstehler

jaredstehler Jul 25, 2016

Contributor

@ssalinas resolved merge conflicts
@tpetr updated to use custom pojo for docker auth config

Contributor

jaredstehler commented Jul 25, 2016

@ssalinas resolved merge conflicts
@tpetr updated to use custom pojo for docker auth config

@ssalinas ssalinas added the hs_staging label Jul 28, 2016

@ssalinas ssalinas modified the milestone: 0.10.0 Jul 29, 2016

@ssalinas ssalinas added the hs_qa label Aug 3, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 3, 2016

Member

🚢

Member

ssalinas commented on ae143a9 Aug 3, 2016

🚢

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 3, 2016

Member

🚢

Member

ssalinas commented on 8d8fc80 Aug 3, 2016

🚢

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 3, 2016

Member

🚢

Member

ssalinas commented on cbbd3ef Aug 3, 2016

🚢

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 3, 2016

Member

🚢

Member

ssalinas commented on 4234b57 Aug 3, 2016

🚢

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 3, 2016

Member

🚢

Member

ssalinas commented on dd0d049 Aug 3, 2016

🚢

@ssalinas ssalinas added the hs_stable label Aug 3, 2016

@ssalinas ssalinas merged commit d6d6e73 into HubSpot:master Aug 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment