Docker auth config#1138
Merged
Merged
Conversation
Contributor
|
Hey @jaredstehler , sry missed this when it was first opened. Can you fix the merge conflicts and I can get this merged through our environments and into master? |
Contributor
|
I thought I had commented already but I must have forgotten to hit Submit or something -- I'd prefer it if we used a custom POJO for these Docker auth fields (something like |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured the easiest way to get this done was simply to use the
AuthConfigclass from the spotify docker client, which has@JsonPropertyannotations already; downside is they are capitalized..also not a huge fan of the test I wrote b/c of the reflection.
Fixes #1098