Truncate long tags; Hover trigger to show the whole thing #1156

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Projects
None yet
3 participants
@Calvinp
Contributor

Calvinp commented Jul 19, 2016

In a modal tagging input, truncate long tags.
On hover, an Popover is opened to show the whole thing.

cc @markhazlewood @tpetr @kwm4385 @wolfd

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Jul 19, 2016

Contributor

Potential improvements:

  • Make the character limit dynamically adjust based on size of the modal (I'm not exactly sure how to find that information).
  • Use a click trigger rather than hover for mobile-friendliness (Currently using hover because it's entirely unclear just from looking that clicking would do anything).

I'd be fine merging this without those improvements but other opinions are welcome.

Contributor

Calvinp commented Jul 19, 2016

Potential improvements:

  • Make the character limit dynamically adjust based on size of the modal (I'm not exactly sure how to find that information).
  • Use a click trigger rather than hover for mobile-friendliness (Currently using hover because it's entirely unclear just from looking that clicking would do anything).

I'd be fine merging this without those improvements but other opinions are welcome.

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Jul 21, 2016

Contributor

LGTM

Contributor

kwm4385 commented Jul 21, 2016

LGTM

@Calvinp Calvinp merged commit 2d5b896 into decaf Jul 21, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Calvinp Calvinp deleted the truncate_long_tags branch Jul 21, 2016

@ssalinas ssalinas modified the milestones: 0.11.0, 0.10.0 Aug 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment