Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long tags; Hover trigger to show the whole thing #1156

Merged
merged 1 commit into from Jul 21, 2016

Conversation

@Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Jul 19, 2016

In a modal tagging input, truncate long tags.
On hover, an Popover is opened to show the whole thing.

cc @markhazlewood @tpetr @kwm4385 @wolfd

@Calvinp
Copy link
Contributor Author

@Calvinp Calvinp commented Jul 19, 2016

Potential improvements:

  • Make the character limit dynamically adjust based on size of the modal (I'm not exactly sure how to find that information).
  • Use a click trigger rather than hover for mobile-friendliness (Currently using hover because it's entirely unclear just from looking that clicking would do anything).

I'd be fine merging this without those improvements but other opinions are welcome.

@kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Jul 21, 2016

LGTM

@Calvinp Calvinp merged commit 2d5b896 into decaf Jul 21, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Calvinp Calvinp deleted the truncate_long_tags branch Jul 21, 2016
@ssalinas ssalinas modified the milestones: 0.11.0, 0.10.0 Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.