Fix the request detail page bounce messages#1158
Merged
Merged
Conversation
added 4 commits
July 19, 2016 16:56
Calvinp
changed the title
| maybeDeployProgress = ( | ||
| <span> | ||
| { | ||
| `Trying to deploy ${targetActiveInstances} of ${instances} |
Contributor
Author
There was a problem hiding this comment.
The problem here is that of didn't make sense. targetActiveInstances is not a fraction of instances in all cases. Instead, if the deploy is successful, it will override instances. If we want to continue mentioning instances, better wording may be Trying to deploy ${targetActiveInstances} (instead of ${instances}) instances.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Please sanity check the wording of the message.
CC @markhazlewood @wolfd @tpetr @kwm4385