Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the request detail page bounce messages #1158

Merged
merged 5 commits into from Jul 28, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Jul 19, 2016

Fixes:

  • The notification stating that the request is bouncing - now it catches all bouncing tasks, even incremental ones, and when there are too many running tasks it uses wording that clearly states that this is ok for now.
  • The notification stating that the request is being deployed - this has the same problem and that will be fixed as well.

Please sanity check the wording of the message.
CC @markhazlewood @wolfd @tpetr @kwm4385

@Calvinp Calvinp changed the title Fix the request detail page bounce messages (WIP) Fix the request detail page bounce messages Jul 21, 2016
</span>
);
} else {
maybeDeployProgress = (
<span>
{
`Trying to deploy ${targetActiveInstances} of ${instances}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that of didn't make sense. targetActiveInstances is not a fraction of instances in all cases. Instead, if the deploy is successful, it will override instances. If we want to continue mentioning instances, better wording may be Trying to deploy ${targetActiveInstances} (instead of ${instances}) instances.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks

@tpetr
Copy link
Contributor

tpetr commented Jul 28, 2016

LGTM

@Calvinp Calvinp merged commit a515feb into decaf Jul 28, 2016
@Calvinp Calvinp deleted the fix_number_of_running_tasks_notifications branch Jul 28, 2016
@ssalinas ssalinas modified the milestones: 0.11.0, 0.10.0 Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants