Conversation
…IDs have a hover button that goes far to the right
| const requestIdToDisplay = Utils.maybe(requestAPI, ['data', 'request', 'id']) || requestId; | ||
|
|
||
| return ( | ||
| <div onMouseOver={() => this.onMouseOver()}> |
There was a problem hiding this comment.
If this.onMouseOver is bound, you can just do onMouseOver={this.onMouseOver}
…overlay trigger explaining this.
|
Trying to have a link pop up on hover that could be clicked to copy things wasn't working. Instead, now the requestID itself can be clicked to copy it. An overlay trigger explains this fact to the user when they hover over the request id. |
| ); | ||
| } | ||
|
|
||
| const requestIdToDisplay = Utils.maybe(requestAPI, ['data', 'request', 'id']) || requestId; |
There was a problem hiding this comment.
why bother with the maybe() if we have the requestId variable?
There was a problem hiding this comment.
Honestly, I don't know. I copied it from what was there before (see line 48 on the other side of the diff), but I can't justify it.
I'll delete it - requestId is marked as required in propTypes after all.
|
I also added the same ability to the Deploy Detail page. It doesn't make sense to add it to the Task Detail page because the task ID isn't displayed as the title. |
|
LGTM |
3 participants
Adds a link next to the request ID to copy it to the clipboard.
TODO: