Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprovements to Task Search #1165
Merged
Conversation
| let firstLoad = true; | ||
|
|
||
| function refresh(props) { | ||
| if (!firstLoad) { |
This comment has been minimized.
This comment has been minimized.
kwm4385
Jul 26, 2016
•
Contributor
If you only want refresh called when the page is first loaded and not again in an interval, just set the optional refreshInterval bool in rootComponent to false. RequestDetail does this https://github.com/HubSpot/Singularity/blob/decaf/SingularityUI/app/components/requestDetail/RequestDetailPage.jsx#L103
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Calvinp commentedJul 21, 2016
•
edited
Makes the following improvements to Task Search:
/taskSearchto/task-searchto be more in line with URLs in the rest of the UI.(Global) Historical TaskstoTask Search.fileglyphicon rather than.... This is also changed in the Task History table in the request detail page.componentWillMount().