Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImprovements to Task Search #1165
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kwm4385
reviewed
Jul 26, 2016
SingularityUI/app/components/taskSearch/TaskSearch.jsx
| let firstLoad = true; | ||
| function refresh(props) { | ||
| if (!firstLoad) { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kwm4385
Jul 26, 2016
Contributor
If you only want refresh called when the page is first loaded and not again in an interval, just set the optional refreshInterval bool in rootComponent to false. RequestDetail does this https://github.com/HubSpot/Singularity/blob/decaf/SingularityUI/app/components/requestDetail/RequestDetailPage.jsx#L103
kwm4385
Jul 26, 2016
•
edited
Edited 1 time
-
kwm4385
edited Jul 26, 2016 (most recent)
Contributor
edited
-
Jul 26, 2016 (most recent)
If you only want refresh called when the page is first loaded and not again in an interval, just set the optional refreshInterval bool in rootComponent to false. RequestDetail does this https://github.com/HubSpot/Singularity/blob/decaf/SingularityUI/app/components/requestDetail/RequestDetailPage.jsx#L103
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
LGTM |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
LGTM |
Calvinp commentedJul 21, 2016
•
edited
Edited 1 time
-
Calvinp
edited Jul 25, 2016 (most recent)
Makes the following improvements to Task Search:
/taskSearchto/task-searchto be more in line with URLs in the rest of the UI.(Global) Historical TaskstoTask Search.fileglyphicon rather than.... This is also changed in the Task History table in the request detail page.componentWillMount().