Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Task Search #1165

Merged
merged 4 commits into from Jul 26, 2016
Merged

Improvements to Task Search #1165

merged 4 commits into from Jul 26, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Jul 21, 2016

Makes the following improvements to Task Search:

  • Changes the URL from /taskSearch to /task-search to be more in line with URLs in the rest of the UI.
  • Changes the header from (Global) Historical Tasks to Task Search.
  • Adds labels for the current search parameters so that it's possible to see current search terms (even if the fields have changed).
  • Removes the JSON button.
  • Changes the log button to be a file glyphicon rather than .... This is also changed in the Task History table in the request detail page.
  • Fixes a bug that caused the table to not update when a new search is performed that returns 0 results.
  • Preemptively fixes the bug that occurred in the deployDetail page - contributed to by making api calls in componentWillMount().

@Calvinp
Copy link
Contributor Author

Calvinp commented Jul 25, 2016

Did it again... Forgot to cc @tpetr @kwm4385 @wolfd

let firstLoad = true;

function refresh(props) {
if (!firstLoad) {
Copy link
Contributor

@kwm4385 kwm4385 Jul 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you only want refresh called when the page is first loaded and not again in an interval, just set the optional refreshInterval bool in rootComponent to false. RequestDetail does this https://github.com/HubSpot/Singularity/blob/decaf/SingularityUI/app/components/requestDetail/RequestDetailPage.jsx#L103

@kwm4385
Copy link
Contributor

kwm4385 commented Jul 26, 2016

LGTM

@wolfd
Copy link
Contributor

wolfd commented Jul 26, 2016

LGTM

@Calvinp Calvinp merged commit 2256348 into decaf Jul 26, 2016
@Calvinp Calvinp deleted the task_search_improvements_round_2 branch Jul 26, 2016
@ssalinas ssalinas modified the milestones: 0.11.0, 0.10.0 Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants