Skip to content

Change API path "/skipHealthchecks" to "/skip-healthchecks"#1166

Merged
ssalinas merged 1 commit into
masterfrom
api_endpoint_uniformity
Jul 25, 2016
Merged

Change API path "/skipHealthchecks" to "/skip-healthchecks"#1166
ssalinas merged 1 commit into
masterfrom
api_endpoint_uniformity

Conversation

@MattCCS

@MattCCS MattCCS commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

This PR changes the "/skipHealthchecks" API path to "/skip-healthchecks" to maintain the dominant style, but preserves the old API paths (marked deprecated) for backwards compatibility. Frontend code, backend code, and READMEs have been modified accordingly.

After a thorough search, I couldn't turn up any other @paths that violated convention.

/cc @ssalinas @Calvinp @wolfd @tpetr

Done to preserve API URL style.
Deprecated @path's preserved and tagged as @deprecated.
@Calvinp

Calvinp commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

Note - we'll have to update this in decaf as well. @wolfd @kwm4385 @tpetr

@ssalinas

Copy link
Copy Markdown
Contributor

👍 LGTM, /fyi @Calvinp @wolfd for pulling this into decaf as well

@ssalinas ssalinas merged commit 8bcb0a9 into master Jul 25, 2016
@ssalinas ssalinas deleted the api_endpoint_uniformity branch July 25, 2016 16:54
@ssalinas ssalinas modified the milestone: 0.9.0 Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants