Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API path "/skipHealthchecks" to "/skip-healthchecks" #1166

Merged
merged 1 commit into from Jul 25, 2016

Conversation

@MattCCS
Copy link
Contributor

@MattCCS MattCCS commented Jul 21, 2016

This PR changes the "/skipHealthchecks" API path to "/skip-healthchecks" to maintain the dominant style, but preserves the old API paths (marked deprecated) for backwards compatibility. Frontend code, backend code, and READMEs have been modified accordingly.

After a thorough search, I couldn't turn up any other @paths that violated convention.

/cc @ssalinas @Calvinp @wolfd @tpetr

Done to preserve API URL style.
Deprecated @path's preserved and tagged as @deprecated.
@Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Jul 21, 2016

Note - we'll have to update this in decaf as well. @wolfd @kwm4385 @tpetr

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Jul 25, 2016

👍 LGTM, /fyi @Calvinp @wolfd for pulling this into decaf as well

@ssalinas ssalinas merged commit 8bcb0a9 into master Jul 25, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the api_endpoint_uniformity branch Jul 25, 2016
@ssalinas ssalinas removed hs_qa labels Jul 25, 2016
@ssalinas ssalinas modified the milestone: 0.9.0 Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.