Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiring pause deletion responsibility shift #1167

Merged
merged 3 commits into from Jul 25, 2016
Merged

Conversation

@MattCCS
Copy link
Contributor

MattCCS commented Jul 22, 2016

This PR changes the Singularity backend to properly delete any existing SingularityExpiringPause on unpause. It likewise changes the frontend to no longer take on that responsibility.

/cc @ssalinas @Calvinp @wolfd @tpetr

MattCCS added 3 commits Jul 22, 2016
The revertAction of an expiring pause was originally to
call revertPause.  Instead, the revertAction is now unpauseRequest.
@wolfd
Copy link
Contributor

wolfd commented Jul 22, 2016

Once this is merged, we still need to address this in decaf

@ssalinas
Copy link
Member

ssalinas commented Jul 25, 2016

@wolfd merging this to master if you want to pull the changes into decaf

@ssalinas ssalinas merged commit e545b84 into master Jul 25, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the expiring_pause_deletion branch Jul 25, 2016
@ssalinas ssalinas modified the milestone: 0.9.0 Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.