Expiring pause deletion responsibility shift #1167

Merged
merged 3 commits into from Jul 25, 2016

Conversation

Projects
None yet
3 participants
@MattCCS
Contributor

MattCCS commented Jul 22, 2016

This PR changes the Singularity backend to properly delete any existing SingularityExpiringPause on unpause. It likewise changes the frontend to no longer take on that responsibility.

/cc @ssalinas @Calvinp @wolfd @tpetr

MattCCS added some commits Jul 22, 2016

Remove revertPause from frontend
The revertAction of an expiring pause was originally to
call revertPause.  Instead, the revertAction is now unpauseRequest.
@wolfd

This comment has been minimized.

Show comment
Hide comment
@wolfd

wolfd Jul 22, 2016

Contributor

Once this is merged, we still need to address this in decaf

Contributor

wolfd commented Jul 22, 2016

Once this is merged, we still need to address this in decaf

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 25, 2016

Member

@wolfd merging this to master if you want to pull the changes into decaf

Member

ssalinas commented Jul 25, 2016

@wolfd merging this to master if you want to pull the changes into decaf

@ssalinas ssalinas merged commit e545b84 into master Jul 25, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the expiring_pause_deletion branch Jul 25, 2016

@ssalinas ssalinas modified the milestone: 0.9.0 Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment