Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TASK_ID environment variable with the singularity task_id #1170

Merged
merged 1 commit into from Aug 5, 2016

Conversation

@ghost
Copy link

@ghost ghost commented Jul 25, 2016

This could be helpful to get the actual TASK_ID of a Singularity task, rather than just the TASK_REQUEST_ID

…ry docker container spawned for a request
@ghost
Copy link
Author

@ghost ghost commented Jul 25, 2016

Our containers rely exclusively on the TASK_ID variable to do some cleanup when webhooks are triggered. I think it is a good addition, because I did not find a very straight forward way to get the exact TASK_ID for a request (there might be multiple tasks in a request)

@ghost
Copy link
Author

@ghost ghost commented Aug 3, 2016

Can we please get this small patch into 0.10?

Having the actual TASK_ID accessible on every container is certainly helpful for referencing purposes.

Thanks

@ssalinas ssalinas modified the milestone: 0.10.0 Aug 4, 2016
@ssalinas ssalinas merged commit 6abdecd into HubSpot:master Aug 5, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ssalinas ssalinas removed hs_qa labels Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.