Do not remove from LB if not yet added #1171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this order of events, we were submitting a LB
ADD
request after theREMOVE
request, with the result that the presence of the REMOVE caused us to never properly remove the task from the LB:1
running2
starts1
entersTASK_RUNNING
2
tasks are healthy and LBADD
/REMOVE
is triggered (but contains the replacement task above)1
becomes healthy and LBADD
is sentThis fixes the deploy logic to only issue the
REMOVE
as part of the deploy if theADD
is already present and successful. If theADD
completes after/during the deploy lb actions, the task will still be properly removed from the LB during cleanup since the LBREMOVE
will not be present.