Do not remove from LB if not yet added#1171
Merged
Merged
Conversation
Contributor
Author
|
This tested well in each of our environments, merging the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this order of events, we were submitting a LB
ADDrequest after theREMOVErequest, with the result that the presence of the REMOVE caused us to never properly remove the task from the LB:1running2starts1entersTASK_RUNNING2tasks are healthy and LBADD/REMOVEis triggered (but contains the replacement task above)1becomes healthy and LBADDis sentThis fixes the deploy logic to only issue the
REMOVEas part of the deploy if theADDis already present and successful. If theADDcompletes after/during the deploy lb actions, the task will still be properly removed from the LB during cleanup since the LBREMOVEwill not be present.