Replace dashes with underscores when searching for matching hosts #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,7 +68,7 @@ export const getFilteredTasks = createSelector( | |||
| _.each(tasks, (t) => { | |||
| t.id = id.extract(t); | |||
| }); | |||
| const hostMatch = fuzzy.filter(filter.filterText, tasks, host); | |||
| const hostMatch = fuzzy.filter(filter.filterText.split('-').join('_'), tasks, host); | |||
There was a problem hiding this comment.
why split() and join() vs. replace()?
There was a problem hiding this comment.
Because I didn't realize I could use a /g flag to make the replacement global.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes hostnames are presented with dashes, sometimes with underscores. On the tasks page they are presented with underscores. Because of this, when linked from a page where they're presented with dashes, no match would be found. This fixes that.