Add timezone field and kill dropdowns if there are less than 5 options #1182

Merged
merged 3 commits into from Aug 2, 2016

Conversation

Projects
None yet
3 participants
@Calvinp
Contributor

Calvinp commented Jul 29, 2016

Adds the timezone field to the New Request Form, and turns dropdowns into buttons if there are less than 5 options.
This looks like this:
screenshot 2016-07-29 14 39 09

cc @kwm4385 @tpetr @wolfd

Add timezone field and kill dropdowns if there are less than 5 option…
…s - instead using buttons, which save a click
@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Jul 29, 2016

Contributor

Is there an enumeration somewhere of valid timezones we can autocomplete/have the user choose from instead of guessing?

Contributor

kwm4385 commented Jul 29, 2016

Is there an enumeration somewhere of valid timezones we can autocomplete/have the user choose from instead of guessing?

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Jul 29, 2016

Contributor

Yes, there are lots of enumerations out there. I'm not sure if any of them correspond exactly to the one in Java.utils.TimeZone though.

Contributor

Calvinp commented Jul 29, 2016

Yes, there are lots of enumerations out there. I'm not sure if any of them correspond exactly to the one in Java.utils.TimeZone though.

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Jul 29, 2016

Contributor

Looks like it's listable though TimeZone.getAvailableIDs();
While it may be overkill to write an endpoint to get that, perhaps we could run it once and just capture the output.

Contributor

kwm4385 commented Jul 29, 2016

Looks like it's listable though TimeZone.getAvailableIDs();
While it may be overkill to write an endpoint to get that, perhaps we could run it once and just capture the output.

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Aug 1, 2016

Contributor

This is now implemented.

Contributor

Calvinp commented Aug 1, 2016

This is now implemented.

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 2, 2016

Member

LGTM

Member

tpetr commented Aug 2, 2016

LGTM

@Calvinp Calvinp merged commit a6bb8a8 into decaf Aug 2, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Calvinp Calvinp deleted the kill_dropdowns_add_timezone_field branch Aug 2, 2016

@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment