Add timezone field and kill dropdowns if there are less than 5 options#1182
Merged
Add timezone field and kill dropdowns if there are less than 5 options#1182
Conversation
…s - instead using buttons, which save a click
Contributor
|
Is there an enumeration somewhere of valid timezones we can autocomplete/have the user choose from instead of guessing? |
Contributor
Author
|
Yes, there are lots of enumerations out there. I'm not sure if any of them correspond exactly to the one in Java.utils.TimeZone though. |
Contributor
|
Looks like it's listable though |
Contributor
Author
|
This is now implemented. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the timezone field to the New Request Form, and turns dropdowns into buttons if there are less than 5 options.
This looks like this:
cc @kwm4385 @tpetr @wolfd