Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone field and kill dropdowns if there are less than 5 options #1182

Merged
merged 3 commits into from Aug 2, 2016

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented Jul 29, 2016

Adds the timezone field to the New Request Form, and turns dropdowns into buttons if there are less than 5 options.
This looks like this:
screenshot 2016-07-29 14 39 09

cc @kwm4385 @tpetr @wolfd

…s - instead using buttons, which save a click
@kwm4385
Copy link
Contributor

kwm4385 commented Jul 29, 2016

Is there an enumeration somewhere of valid timezones we can autocomplete/have the user choose from instead of guessing?

@Calvinp
Copy link
Contributor Author

Calvinp commented Jul 29, 2016

Yes, there are lots of enumerations out there. I'm not sure if any of them correspond exactly to the one in Java.utils.TimeZone though.

@kwm4385
Copy link
Contributor

kwm4385 commented Jul 29, 2016

Looks like it's listable though TimeZone.getAvailableIDs();
While it may be overkill to write an endpoint to get that, perhaps we could run it once and just capture the output.

@Calvinp
Copy link
Contributor Author

Calvinp commented Aug 1, 2016

This is now implemented.

@tpetr
Copy link
Member

tpetr commented Aug 2, 2016

LGTM

@Calvinp Calvinp merged commit a6bb8a8 into decaf Aug 2, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Calvinp Calvinp deleted the kill_dropdowns_add_timezone_field branch Aug 2, 2016
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.