Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail differently if request data not present during deploy check #1184

Merged
merged 2 commits into from
Aug 5, 2016

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Aug 2, 2016

@tpetr
Copy link
Contributor

tpetr commented Aug 2, 2016

LGTM, could we add a unit test for this situation?

@ssalinas
Copy link
Member Author

ssalinas commented Aug 2, 2016

FYI, in testing I found this was only triggered when the deployChecker ran before the cleaner after a request delete during a deploy. If the cleaner has already run, we do not hit the optional.get() error because the pending deploy is removed by the cleaner.

@ssalinas ssalinas modified the milestone: 0.10.0 Aug 4, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Aug 5, 2016

Forgot to comment earlier that unit test was added, going to merge

@ssalinas ssalinas merged commit 7a509ed into master Aug 5, 2016
@ssalinas ssalinas deleted the no_get_absent branch August 5, 2016 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants