/ Singularity Public
sort task history updates by ExtendedTaskState enum ordinal, not timestamp #1188
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
I found a few cases where it could happen that what we would consider the 'current state' of the task, is not the update that has the latest timestamp:
This PR updates the sort called when fetching task histories to sort by the
ExtendedTaskSTateordinal instead of relying only on timestamp. This should give us the correct 'current' state in all cases since the enum is defined in the order we expect statuses to progress during the task lifecycle.
/cc @tpetr @stevenschlansker @subratbasnet #1187