Merged
Conversation
added 2 commits
August 5, 2016 13:35
…'ui', and 's3' are ok because they are useful and informative when they are used, unlike 'hc' (for healthchecks)
Contributor
Author
Merged
added 12 commits
August 10, 2016 09:42
Closed
added 5 commits
August 10, 2016 14:30
| step={1} | ||
| value={this.props.value ? duration.hours() : ''} | ||
| onChange={(e) => this.handleChange(e)} | ||
| onChange={(event) => this.handleChange(event)} |
Contributor
There was a problem hiding this comment.
These could probably be shortened just to onChange={this.handleChange}
Contributor
Author
There was a problem hiding this comment.
When making this change, I found a bug (that is present in decaf too). I'm working on fixing that.
added 5 commits
August 10, 2016 16:18
added 7 commits
August 11, 2016 17:12
…eir own functions
…eir own functions on slaves page as well
| <UITable | ||
| data={pausedRequests} | ||
| keyGetter={(r) => r.request.id} | ||
| keyGetter={(request) => request.request.id} |
Contributor
There was a problem hiding this comment.
these are actually requestParents, but we don't do a good job of labeling them...
Contributor
Author
There was a problem hiding this comment.
Yeah, I'm realizing that. I'm willing to go through and change them all - it's probably worth doing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
id,ui, ands3are ok because they are useful and informative when they are used, unlikehc(forhealthCheck)moment.updateLocale()instead ofmoment.locale()to get rid of the deprecated warning.