New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy failure message for non-task-specific failures #1194

Merged
merged 3 commits into from Aug 22, 2016

Conversation

Projects
None yet
1 participant
@ssalinas
Member

ssalinas commented Aug 5, 2016

If we hit a case where there is a non-task-specific failure (such as the not enough resources to launch all tasks one), we should use the correct failure message in the deploy result and omit the list of deploy failures. In other words the calculated one takes precedence

/cc @gchomatas

@ssalinas ssalinas added the hs_staging label Aug 8, 2016

ssalinas added some commits Aug 8, 2016

@ssalinas ssalinas modified the milestones: 0.11.0, 0.10.1 Aug 19, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 22, 2016

Member

Merging this for 0.10.1 bug fix release

Member

ssalinas commented Aug 22, 2016

Merging this for 0.10.1 bug fix release

@ssalinas ssalinas merged commit b3bb5b9 into master Aug 22, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the failure_messages branch Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment