Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Form Improvements #1195

Merged
merged 11 commits into from Aug 18, 2016
Merged

Request Form Improvements #1195

merged 11 commits into from Aug 18, 2016

Conversation

@Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Aug 8, 2016

This makes the following improvements to the Request Form and Form components:

  • Adds missing fields so that requests can be edited without erasing those attributes.
  • This involved creating a new MapInput component to handle the emailconfigurationOverrides field.
  • Several components were made functional or otherwise improved.
  • This includes the request form itself - now it's a functional component, which greatly improves performance.

As a future improvement, the new deploy form can also be upgraded to make use of the new component for its map fields.

cc @tpetr @kwm4385 @wolfd

@Calvinp Calvinp merged commit ce28fd0 into decaf Aug 18, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Calvinp Calvinp deleted the add_missing_fields_request_form branch Aug 18, 2016
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.