Request groups page - #1196
Merged
Merged
Conversation
| import { buildApiAction } from './base'; | ||
|
|
||
| export const FetchGroups = buildApiAction( | ||
| 'FETCH_GROUPS', |
Contributor
There was a problem hiding this comment.
i'd suggest being explicit with the naming (FetchRequestGroups, FETCH_REQUEST_GROUPS), we also have the concept of groups for authentication (which may be featured more prominently in the future)
| <Route path="requests/new" component={RequestForm} /> | ||
| <Route path="requests/edit/:requestId" component={RequestForm} /> | ||
| <Route path="requests(/:state)(/:subFilter)(/:searchFilter)" component={RequestsPage} /> | ||
| <Route path="group/:groupId" component={Group} store={props.store} /> |
Contributor
There was a problem hiding this comment.
i dont think the store field is necessary
Contributor
Author
There was a problem hiding this comment.
Yep you're right, leftover from an earlier experiment.
| deploy: state.api.deploy.data, | ||
| taskHistory: state.api.taskHistoryForDeploy.data, | ||
| isTaskHistoryFetching: state.api.taskHistoryForDeploy.isFetching, | ||
| group: state.api.deploy.data.deploy && _.first(_.filter(state.api.requestGroups.data, (g) => _.contains(g.requestIds, state.api.deploy.data.deploy.requestId))), |
Contributor
There was a problem hiding this comment.
I'm adding a linting check to prohibit one-letter variable names (See #1192). Might want to change g to groupToCheck, or something more descriptive.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a new Group page (
/group/:groupId) which shows details for all requests contained in it.Also adds a breadcrumb item for requests, deploys, and tasks which are part of a group.
The metadata button displays a modal with copyable infoboxes. (button only is only shown if the group has metadata)
@tpetr @wolfd @Calvinp