Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry support #1199

Merged
merged 1 commit into from Aug 10, 2016
Merged

sentry support #1199

merged 1 commit into from Aug 10, 2016

Conversation

kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Aug 9, 2016

This PR allows sentry to support the UI by surfacing errors out of the main rendering promise in rootComponent. Sentry can't detect errors inside promises because they aren't bubbled up to window.onerror. (Actual sentry tracking code is injected normally through SINGULARITY_EXTRA_SCRIPTS.

@tpetr @Calvinp @wolfd

{{#extraScript}}
{{{extraScript}}}
{{/extraScript}}
<script src="{{{staticRoot}}}/js/app.js"></script>
Copy link
Contributor

@tpetr tpetr Aug 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this ordering affect things like our Heap integration? /cc @wolfd

Copy link
Contributor Author

@kwm4385 kwm4385 Aug 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so (wolf can verify). Sentry does need to be loaded before our code though.

@kwm4385 kwm4385 merged commit 828a08f into decaf Aug 10, 2016
1 of 2 checks passed
@kwm4385 kwm4385 deleted the sentry branch Aug 10, 2016
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants