Aggregate Tailer fix #1200

Merged
merged 5 commits into from Aug 10, 2016

Conversation

Projects
None yet
2 participants

kwm4385 added some commits Aug 10, 2016

@@ -58,13 +58,14 @@ class LogLines extends React.Component {
taskId={taskId}
timestamp={timestamp}
isHighlighted={offset === initialOffset}
- color={colorMap[taskId]} />;
+ color={colorMap[taskId]}

This comment has been minimized.

@tpetr

tpetr Aug 10, 2016

Member

might be misreading, but doesn't this need the />?

@tpetr

tpetr Aug 10, 2016

Member

might be misreading, but doesn't this need the />?

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Aug 10, 2016

Contributor

WIP: Fixing other bugs with the aggregate view (auto decaffeinate did a number on it)

Contributor

kwm4385 commented Aug 10, 2016

WIP: Fixing other bugs with the aggregate view (auto decaffeinate did a number on it)

kwm4385 added some commits Aug 10, 2016

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Aug 10, 2016

Contributor

Everything seems to be working except for the unified instance switching, but as discussed in Slack, this is already affecting QA and PROD.

Contributor

kwm4385 commented Aug 10, 2016

Everything seems to be working except for the unified instance switching, but as discussed in Slack, this is already affecting QA and PROD.

@@ -256,6 +256,7 @@ export const taskGroupFetchPrevious = taskGroupId =>
}
dispatch({taskGroupId, type: 'LOG_REQUEST_START'});
+ tasks = _.without(tasks, undefined);

This comment has been minimized.

@tpetr

tpetr Aug 10, 2016

Member

just curious, do we know why undefined was here in the first place?

@tpetr

tpetr Aug 10, 2016

Member

just curious, do we know why undefined was here in the first place?

This comment has been minimized.

@kwm4385

kwm4385 Aug 10, 2016

Contributor

I'm not sure, there seems to be an issue with how the actions are removing instances from the list but I wasn't able to pinpoint where. This might actually be a no op since this is related to the same problem on QA and PROD.

@kwm4385

kwm4385 Aug 10, 2016

Contributor

I'm not sure, there seems to be an issue with how the actions are removing instances from the list but I wasn't able to pinpoint where. This might actually be a no op since this is related to the same problem on QA and PROD.

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 10, 2016

Member

LGTM

Member

tpetr commented Aug 10, 2016

LGTM

@tpetr tpetr merged commit 428a30d into decaf Aug 10, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016

@ssalinas ssalinas deleted the tailer-fix branch Nov 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment