New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case-sensitive paths plugin #1202

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Aug 10, 2016

This adds the case-sensitive paths plugin Singularity UI - thus preventing the issue where builds succeed locally but not in Jenkins because the OSX filesystem is case-insensitive.
Now it'll fail locally with this error:

ERROR in ./app/components/tasks/TasksPage.jsx
Module not found: Error: [CaseSensitivePathsPlugin] `/Users/cpomerantz/repos/Singularity/SingularityUI/app/rootcomponent.jsx` does not match the corresponding path on disk `rootComponent.jsx`.
 @ ./app/components/tasks/TasksPage.jsx 17:21-51

cc @tpetr @wolfd @kwm4385

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 10, 2016

Member

LGTM

Member

tpetr commented Aug 10, 2016

LGTM

@Calvinp Calvinp merged commit 9a5d2aa into decaf Aug 10, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@Calvinp Calvinp deleted the case_sensitive_paths_plugin branch Aug 10, 2016

@Calvinp Calvinp referenced this pull request Aug 10, 2016

Closed

Redo gulp & webpack (WIP) #1157

@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment