UI support for absent deploy field #1207

Merged
merged 3 commits into from Aug 12, 2016

Conversation

Projects
None yet
3 participants
@kwm4385
Contributor

kwm4385 commented Aug 11, 2016

In cases where the deploy field was absent from the deploy object, the UI would fail. This PR short circuits the render to display an empty message in this case.

image

@tpetr @wolfd @Calvinp @ssalinas

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 11, 2016

Member

@kwm4385 we should still be able to show the task history. just wouldn't have the Info section

Member

ssalinas commented Aug 11, 2016

@kwm4385 we should still be able to show the task history. just wouldn't have the Info section

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Aug 11, 2016

Contributor

Readded those sections
image

Contributor

kwm4385 commented Aug 11, 2016

Readded those sections
image

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 12, 2016

Member

LGTM

Member

tpetr commented Aug 12, 2016

LGTM

@kwm4385 kwm4385 merged commit b14e467 into decaf Aug 12, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kwm4385 kwm4385 deleted the minimal-deploy-ui branch Aug 12, 2016

@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment