Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI support for absent deploy field #1207

Merged
merged 3 commits into from Aug 12, 2016
Merged

UI support for absent deploy field #1207

merged 3 commits into from Aug 12, 2016

Conversation

@kwm4385
Copy link
Contributor

kwm4385 commented Aug 11, 2016

In cases where the deploy field was absent from the deploy object, the UI would fail. This PR short circuits the render to display an empty message in this case.

image

@tpetr @wolfd @Calvinp @ssalinas

@ssalinas
Copy link
Member

ssalinas commented Aug 11, 2016

@kwm4385 we should still be able to show the task history. just wouldn't have the Info section

@kwm4385
Copy link
Contributor Author

kwm4385 commented Aug 11, 2016

Readded those sections
image

@tpetr
Copy link
Member

tpetr commented Aug 12, 2016

LGTM

@kwm4385 kwm4385 merged commit b14e467 into decaf Aug 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kwm4385 kwm4385 deleted the minimal-deploy-ui branch Aug 12, 2016
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.