Skip to content

UI support for absent deploy field#1207

Merged
kwm4385 merged 3 commits intodecaffrom
minimal-deploy-ui
Aug 12, 2016
Merged

UI support for absent deploy field#1207
kwm4385 merged 3 commits intodecaffrom
minimal-deploy-ui

Conversation

@kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Aug 11, 2016

In cases where the deploy field was absent from the deploy object, the UI would fail. This PR short circuits the render to display an empty message in this case.

image

@tpetr @wolfd @Calvinp @ssalinas

@ssalinas
Copy link
Member

@kwm4385 we should still be able to show the task history. just wouldn't have the Info section

@kwm4385
Copy link
Contributor Author

kwm4385 commented Aug 11, 2016

Readded those sections
image

@tpetr
Copy link
Contributor

tpetr commented Aug 12, 2016

LGTM

@kwm4385 kwm4385 merged commit b14e467 into decaf Aug 12, 2016
@kwm4385 kwm4385 deleted the minimal-deploy-ui branch August 12, 2016 16:32
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants