New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name all the modals that don't already have a name #1209

Merged
merged 1 commit into from Aug 12, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Aug 11, 2016

Exactly what it says on the tin - gives a name to all the modals that didn't already have a name.

eg.
screenshot 2016-08-11 16 50 18

cc @tpetr @wolfd @kwm4385

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 12, 2016

Member

LGTM

Member

tpetr commented Aug 12, 2016

LGTM

@Calvinp Calvinp merged commit fedb07b into decaf Aug 12, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Calvinp Calvinp deleted the name_modals branch Aug 12, 2016

@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment