Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the wait for replacement task option when killing tasks in certain request types #1210

Merged

Conversation

@Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Aug 12, 2016

It doesn't make sense to show that option if there won't be a replacement task - so don't show it for scheduled, on demand, or run once requests.

cc @tpetr @kwm4385 @wolfd

…equest that is scheduled, on demand, or run once
@tpetr
Copy link
Member

@tpetr tpetr commented Aug 16, 2016

LGTM

@Calvinp Calvinp merged commit 7c25397 into decaf Aug 16, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@Calvinp Calvinp deleted the dont_show_wait_for_replacement_task_for_certain_request_types branch Aug 16, 2016
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.