Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the wait for replacement task option when killing tasks in certain request types #1210

Merged

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Aug 12, 2016

It doesn't make sense to show that option if there won't be a replacement task - so don't show it for scheduled, on demand, or run once requests.

cc @tpetr @kwm4385 @wolfd

…equest that is scheduled, on demand, or run once
@tpetr
Copy link
Contributor

tpetr commented Aug 16, 2016

LGTM

@Calvinp Calvinp merged commit 7c25397 into decaf Aug 16, 2016
@Calvinp Calvinp deleted the dont_show_wait_for_replacement_task_for_certain_request_types branch August 16, 2016 20:19
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants