New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for presence of promise before attempting to catch errors #1215

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Projects
None yet
2 participants
@kwm4385
Contributor

kwm4385 commented Aug 12, 2016

Refresh doesn't require a promise to always be returned, so check for one before attempting to catch errors for sentry. Fixes "catch of undefined sentry".

@tpetr @wolfd @Calvinp

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 15, 2016

Member

LGTM

Member

tpetr commented Aug 15, 2016

LGTM

@kwm4385 kwm4385 merged commit dbe1741 into decaf Aug 15, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kwm4385 kwm4385 deleted the fix-catch branch Aug 15, 2016

@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment