Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for presence of promise before attempting to catch errors #1215

Merged
merged 1 commit into from Aug 15, 2016

Conversation

kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Aug 12, 2016

Refresh doesn't require a promise to always be returned, so check for one before attempting to catch errors for sentry. Fixes "catch of undefined sentry".

@tpetr @wolfd @Calvinp

@tpetr
Copy link
Contributor

tpetr commented Aug 15, 2016

LGTM

@kwm4385 kwm4385 merged commit dbe1741 into decaf Aug 15, 2016
@kwm4385 kwm4385 deleted the fix-catch branch August 15, 2016 19:32
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants