New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the back button when navigating through files on the task detail page #1225

Merged
merged 1 commit into from Aug 18, 2016

Conversation

Projects
None yet
4 participants
@Calvinp
Contributor

Calvinp commented Aug 18, 2016

Fixes the bug that caused the back button not to work while navigating through file system on the TaskDetail page.

The problem was it wasn't actually using the route to determine the file path, but to set state that determined the file path. The state wouldn't be updated when the back button was hit. The fix was to not use state at all.

cc @tpetr @kwm4385 @wolfd

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Aug 18, 2016

Contributor

Beat me to it lol
LGTM

Contributor

kwm4385 commented Aug 18, 2016

Beat me to it lol
LGTM

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Aug 18, 2016

Contributor

This actually turned out to be a great example for why using props to set initial state is bad.

Contributor

Calvinp commented Aug 18, 2016

This actually turned out to be a great example for why using props to set initial state is bad.

@jonathanwgoodwin

This comment has been minimized.

Show comment
Hide comment
Member

jonathanwgoodwin commented Aug 18, 2016

Thanks @Calvinp !

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 18, 2016

Member

LGTM

Member

tpetr commented Aug 18, 2016

LGTM

@Calvinp Calvinp merged commit 18fcf3e into decaf Aug 18, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@Calvinp Calvinp deleted the fix_files_back_button branch Aug 18, 2016

@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment