Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the back button when navigating through files on the task detail page #1225

Merged
merged 1 commit into from Aug 18, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Aug 18, 2016

Fixes the bug that caused the back button not to work while navigating through file system on the TaskDetail page.

The problem was it wasn't actually using the route to determine the file path, but to set state that determined the file path. The state wouldn't be updated when the back button was hit. The fix was to not use state at all.

cc @tpetr @kwm4385 @wolfd

@kwm4385
Copy link
Contributor

kwm4385 commented Aug 18, 2016

Beat me to it lol
LGTM

@Calvinp
Copy link
Contributor Author

Calvinp commented Aug 18, 2016

This actually turned out to be a great example for why using props to set initial state is bad.

@jonathanwgoodwin
Copy link
Member

Thanks @Calvinp !

@tpetr
Copy link
Contributor

tpetr commented Aug 18, 2016

LGTM

@Calvinp Calvinp merged commit 18fcf3e into decaf Aug 18, 2016
@Calvinp Calvinp deleted the fix_files_back_button branch Aug 18, 2016
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants