Run Now UI Service Restoration #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually find a task
Calvinp
changed the title
|
Looks like the poller is working properly. |
| this.props.runNow(data).then((response) => { | ||
| if (response.error) { | ||
| Messenger().post({ | ||
| message: '<p>This request cannot be run now. This is likely because it is already running.</p>', | ||
| type: 'error' | ||
| }); | ||
| } else if (_.contains([RunNowModal.AFTER_TRIGGER.SANDBOX.value, RunNowModal.AFTER_TRIGGER.TAIL.value], data.afterTrigger)) { | ||
| const requestId = Utils.maybe(response, ['data', 'request', 'id']); |
There was a problem hiding this comment.
What happens when this maybe returns undefined?
There was a problem hiding this comment.
The poller still tries to find the task, but never will because it's requesting /api/history/request/undefined/run/${runId}.
It might make sense to not even try to poll if that's undefined.
EDIT - This is implemented.
added 6 commits
August 22, 2016 11:56
|
Brought back the multi-input for command line arguments.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
This brings that functionality back.
cc @tpetr @wolfd