New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle deleted requests #1235

Merged
merged 2 commits into from Aug 22, 2016

Conversation

Projects
None yet
3 participants
@Calvinp
Contributor

Calvinp commented Aug 19, 2016

Instead of showing the not found page when a user navigates to the detail page of a deleted request, show the requestId, an alert saying that the request has been deleted, and the request history.

screenshot 2016-08-19 15 47 34

cc @tpetr @ssalinas @wolfd

@Calvinp Calvinp added the hs_staging label Aug 22, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 22, 2016

Member

LGTM

Member

tpetr commented Aug 22, 2016

LGTM

@ssalinas ssalinas merged commit a12fa05 into master Aug 22, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ssalinas ssalinas deleted the handle_deleted_requests branch Aug 22, 2016

@ssalinas ssalinas modified the milestone: 0.10.1 Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment