Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use the relative path, taking out the base URL #1238

Merged
merged 1 commit into from Aug 22, 2016
Merged

Always use the relative path, taking out the base URL #1238

merged 1 commit into from Aug 22, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Aug 22, 2016 •
edited

Parses the URL base (eg. http://localhost:7099) out of the config.appRoot to avoid 404s on first load.

Fixes #1237

cc @tpetr @ssalinas

@Calvinp Calvinp mentioned this pull request Aug 22, 2016
Closed
@ssalinas
Copy link
Member

👍

@ssalinas ssalinas merged commit 6bacf05 into master Aug 22, 2016
@ssalinas ssalinas deleted the use_relative_path branch August 22, 2016 15:09
@ssalinas ssalinas modified the milestone: 0.10.1 Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Calvinp @ssalinas