Skip to content

/ Singularity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use the relative path, taking out the base URL #1238

Merged
merged 1 commit into from Aug 22, 2016
Merged

Always use the relative path, taking out the base URL #1238

merged 1 commit into from Aug 22, 2016

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented Aug 22, 2016 •
edited

Parses the URL base (eg. http://localhost:7099) out of the config.appRoot to avoid 404s on first load.

Fixes #1237

cc @tpetr @ssalinas
@Calvinp
Always use the relative path, taking out the base URL
Loading status checks…
249145e
@Calvinp Calvinp mentioned this pull request Aug 22, 2016
Closed
@ssalinas
Copy link
Member

ssalinas commented Aug 22, 2016

👍
@ssalinas ssalinas merged commit 6bacf05 into master Aug 22, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the use_relative_path branch Aug 22, 2016
@ssalinas ssalinas removed hs_qa labels Aug 22, 2016
@ssalinas ssalinas modified the milestone: 0.10.1 Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Calvinp @ssalinas
You can’t perform that action at this time.