Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add href to navitems #1239

Merged
merged 2 commits into from
Aug 24, 2016
Merged

Add href to navitems #1239

merged 2 commits into from
Aug 24, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Aug 22, 2016

Changes global nav:

  • No longer use react-bootstrap nav items, since they were causing weird tab issues.
  • Add an href (or Link to prop) to all the links to allow opening the correct link in a new tab.

cc @tpetr @wolfd

@ssalinas ssalinas modified the milestone: 0.10.1 Aug 22, 2016
@tpetr
Copy link
Contributor

tpetr commented Aug 23, 2016

LGTM

@ssalinas ssalinas merged commit e01fb8a into master Aug 24, 2016
@ssalinas ssalinas deleted the add_href_to_navitems branch August 24, 2016 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Calvinp @tpetr @ssalinas