New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add href to navitems #1239

Merged
merged 2 commits into from Aug 24, 2016

Conversation

Projects
None yet
3 participants
@Calvinp
Contributor

Calvinp commented Aug 22, 2016

Changes global nav:

  • No longer use react-bootstrap nav items, since they were causing weird tab issues.
  • Add an href (or Link to prop) to all the links to allow opening the correct link in a new tab.

cc @tpetr @wolfd

@ssalinas ssalinas modified the milestone: 0.10.1 Aug 22, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 23, 2016

Member

LGTM

Member

tpetr commented Aug 23, 2016

LGTM

@ssalinas ssalinas added the hs_stable label Aug 24, 2016

@ssalinas ssalinas merged commit e01fb8a into master Aug 24, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the add_href_to_navitems branch Aug 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment