Skip to content

Add href to navitems#1239

Merged
ssalinas merged 2 commits intomasterfrom
add_href_to_navitems
Aug 24, 2016
Merged

Add href to navitems#1239
ssalinas merged 2 commits intomasterfrom
add_href_to_navitems

Conversation

@Calvinp
Copy link
Copy Markdown
Contributor

@Calvinp Calvinp commented Aug 22, 2016

Changes global nav:

  • No longer use react-bootstrap nav items, since they were causing weird tab issues.
  • Add an href (or Link to prop) to all the links to allow opening the correct link in a new tab.

cc @tpetr @wolfd

@ssalinas ssalinas modified the milestone: 0.10.1 Aug 22, 2016
@tpetr
Copy link
Copy Markdown
Contributor

tpetr commented Aug 23, 2016

LGTM

@ssalinas ssalinas merged commit e01fb8a into master Aug 24, 2016
@ssalinas ssalinas deleted the add_href_to_navitems branch August 24, 2016 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants