New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Duration Fields String Inputs Again #1246

Merged
merged 4 commits into from Aug 26, 2016

Conversation

Projects
None yet
3 participants
@Calvinp
Contributor

Calvinp commented Aug 23, 2016

Duration fields used to be string inputs that were validated and parsed by the juration library.
Then we changed them, but that change introduced a 24 hour maximum duration restriction.
This reverts duration fields to strings parsed by juration and removes that maximum.

cc @tpetr @wolfd

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Aug 23, 2016

Member

LGTM

Member

tpetr commented Aug 23, 2016

LGTM

@ssalinas ssalinas modified the milestone: 0.11.0 Aug 24, 2016

@ssalinas ssalinas added the hs_stable label Aug 25, 2016

@ssalinas ssalinas merged commit dd27879 into master Aug 26, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the return_duration_to_stringinput branch Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment