Reorganize task label colors #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 20, 2016 13:39
These comments didn't cover a number of edge cases and were very specific to load-balanced requests. Overall I think they would be more confusing than helpful, so going to remove them from the code for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #1162 against master.
To reiterate, task state labels are organized in a more consistent way.
Credit to @kwm4385 for the following organizational scheme:
cc @tpetr @ssalinas @markhazlewood
ETA - Missing from that chart are
TASK_ERRORandTASK_STAGING.TASK_ERRORis red, andTASK_STAGINGis light blue.