New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize task label colors #1248

Merged
merged 6 commits into from Sep 1, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Aug 23, 2016

Reopening #1162 against master.

To reiterate, task state labels are organized in a more consistent way.

Credit to @kwm4385 for the following organizational scheme:

226f6866-4e8c-11e6-911a-db46d3e871bd

Green: Task is running and guaranteed to be serving requests at this time
Light/dark blue: Task may not be serving requests, but the state is expected and no action is needed. Darker means the state is terminal.
Red: Something went wrong and you may want to investigate
Orange: Something is wrong but action might not be required on your part
Grey: Task is waiting/not relevent now

cc @tpetr @ssalinas @markhazlewood

ETA - Missing from that chart are TASK_ERROR and TASK_STAGING. TASK_ERROR is red, and TASK_STAGING is light blue.

@ssalinas ssalinas modified the milestone: 0.11.0 Aug 24, 2016

update comments for task state colors
These comments didn't cover a number of edge cases and were very specific to load-balanced requests. Overall I think they would be more confusing than helpful, so going to remove them from the code for now

@ssalinas ssalinas merged commit 5ae3120 into master Sep 1, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the reorganize_task_label_colors branch Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment