New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate compression formats and viewing compressed files in UI #1259

Merged
merged 31 commits into from Nov 28, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Aug 31, 2016

This adds support for other compression formats besides gzip to be used for logrotate. The main target of this PR is support for bzip2, but currently LogrotateCompressionSettings is not enforcing any particular extensions, so we can extend to other formats later if needed. I had started adding supported log formats as an enum, but realized I would need the additional fields for executable locations anyways and might as well leave the config more open.

Changes will be needed in logfetch to handle bz2 files as well and will come in a separate PR.

note : Also added a few more to the not tail-able files list in the ui as part of this too

/cc @tpetr @MattCCS

ssalinas added some commits Aug 31, 2016

Show outdated Hide outdated ...om/hubspot/singularity/executor/config/LogrotateCompressionSettings.java
this.compressExt = compressExt;
}
public static LogrotateCompressionSettings gzip() {

This comment has been minimized.

@tpetr

tpetr Aug 31, 2016

Member

i'd consider renaming this to default(), since it's just an implementation detail of logrotate that it's using gzip to compress

@tpetr

tpetr Aug 31, 2016

Member

i'd consider renaming this to default(), since it's just an implementation detail of logrotate that it's using gzip to compress

This comment has been minimized.

@ssalinas

ssalinas Sep 1, 2016

Member

default is a reserved word/identifier in java, you can't name a method that. Renamed to empty() instead

@ssalinas

ssalinas Sep 1, 2016

Member

default is a reserved word/identifier in java, you can't name a method that. Renamed to empty() instead

@ssalinas ssalinas changed the title from support for bzip2 compression to support for alternate logrotate compression Sep 1, 2016

@ssalinas ssalinas modified the milestone: 0.11.0 Sep 9, 2016

@ssalinas ssalinas modified the milestones: 0.11.0, 0.12.0 Sep 14, 2016

@ssalinas ssalinas changed the title from support for alternate logrotate compression to Alternate compression formats and viewing compressed files in UI Sep 14, 2016

@ssalinas ssalinas added the hs_qa label Sep 15, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 19, 2016

Member

🚢

Member

tpetr commented on 68d387e Sep 19, 2016

🚢

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 19, 2016

Member

🚢

Member

tpetr commented on 4869e23 Sep 19, 2016

🚢

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 19, 2016

Member

🚢

Member

tpetr commented on 8a21a44 Sep 19, 2016

🚢

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 19, 2016

Member

🚢

Member

tpetr commented on 5ff6484 Sep 19, 2016

🚢

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 19, 2016

Member

🚢

Member

tpetr commented on a4434e2 Sep 19, 2016

🚢

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 19, 2016

Member

🚢

Member

tpetr commented on 9087f45 Sep 19, 2016

🚢

@ssalinas ssalinas added the hs_stable label Sep 19, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 21, 2016

Member

🚢

Member

tpetr commented on c70dacf Sep 21, 2016

🚢

@ssalinas ssalinas modified the milestones: 0.12.0, 0.13.0 Nov 4, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Nov 28, 2016

Member

🚢

Member

ssalinas commented on 1cd30b5 Nov 28, 2016

🚢

@tpetr tpetr merged commit 4bdeea5 into master Nov 28, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@ssalinas ssalinas deleted the compression_formats branch Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment