Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate compression formats and viewing compressed files in UI #1259

Merged
merged 31 commits into from Nov 28, 2016

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Aug 31, 2016

This adds support for other compression formats besides gzip to be used for logrotate. The main target of this PR is support for bzip2, but currently LogrotateCompressionSettings is not enforcing any particular extensions, so we can extend to other formats later if needed. I had started adding supported log formats as an enum, but realized I would need the additional fields for executable locations anyways and might as well leave the config more open.

Changes will be needed in logfetch to handle bz2 files as well and will come in a separate PR.

note : Also added a few more to the not tail-able files list in the ui as part of this too

/cc @tpetr @MattCCS

this.compressExt = compressExt;
}

public static LogrotateCompressionSettings gzip() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd consider renaming this to default(), since it's just an implementation detail of logrotate that it's using gzip to compress

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is a reserved word/identifier in java, you can't name a method that. Renamed to empty() instead

@ssalinas ssalinas changed the title support for bzip2 compression support for alternate logrotate compression Sep 1, 2016
@ssalinas ssalinas modified the milestone: 0.11.0 Sep 9, 2016
@ssalinas ssalinas removed this from the 0.11.0 milestone Sep 14, 2016
@ssalinas ssalinas modified the milestones: 0.12.0, 0.11.0 Sep 14, 2016
@ssalinas ssalinas changed the title support for alternate logrotate compression Alternate compression formats and viewing compressed files in UI Sep 14, 2016
@ssalinas ssalinas added the hs_qa label Sep 15, 2016
@ssalinas ssalinas modified the milestones: 0.12.0, 0.13.0 Nov 4, 2016
@tpetr tpetr merged commit 4bdeea5 into master Nov 28, 2016
@tpetr tpetr removed hs_qa labels Nov 28, 2016
@ssalinas ssalinas deleted the compression_formats branch February 8, 2017 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants