Alternate compression formats and viewing compressed files in UI #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.compressExt = compressExt; | ||
| } | ||
|
|
||
| public static LogrotateCompressionSettings gzip() { |
There was a problem hiding this comment.
i'd consider renaming this to default(), since it's just an implementation detail of logrotate that it's using gzip to compress
There was a problem hiding this comment.
default is a reserved word/identifier in java, you can't name a method that. Renamed to empty() instead
ssalinas
changed the title
ssalinas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for other compression formats besides gzip to be used for logrotate. The main target of this PR is support for bzip2, but currently
LogrotateCompressionSettingsis not enforcing any particular extensions, so we can extend to other formats later if needed. I had started adding supported log formats as an enum, but realized I would need the additional fields for executable locations anyways and might as well leave the config more open.Changes will be needed in logfetch to handle bz2 files as well and will come in a separate PR.
note : Also added a few more to the not tail-able files list in the ui as part of this too
/cc @tpetr @MattCCS