Support for setting user in default executor #1262

Merged
merged 6 commits into from Sep 2, 2016

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Sep 1, 2016

/fixes #1261

@kchaliki

This comment has been minimized.

Show comment
Hide comment
@kchaliki

kchaliki Sep 1, 2016

Contributor

@ssalinas thanks for the addition

Contributor

kchaliki commented Sep 1, 2016

@ssalinas thanks for the addition

@ssalinas ssalinas added the hs_qa label Sep 1, 2016

@@ -381,6 +381,10 @@ private void prepareCustomExecutor(final TaskInfo.Builder bldr, final Singularit
private void prepareCommand(final TaskInfo.Builder bldr, final SingularityTaskId taskId, final SingularityTaskRequest task, final Protos.Offer offer, final Optional<long[]> ports) {
CommandInfo.Builder commandBldr = CommandInfo.newBuilder();
+ if (task.getDeploy().getUser().isPresent()) {
+ commandBldr.setUser(task.getDeploy().getUser().get());

This comment has been minimized.

@tpetr

tpetr Sep 2, 2016

Member

Can we add this corresponding change to prepareCustomExecutor() too? I can see some utility in being able to control what user the custom executor is launched as.

@tpetr

tpetr Sep 2, 2016

Member

Can we add this corresponding change to prepareCustomExecutor() too? I can see some utility in being able to control what user the custom executor is launched as.

This comment has been minimized.

@ssalinas

ssalinas Sep 2, 2016

Member

We already had customExecutorUser for this purpose, but it had been deprecated for a while now. I've officially removed it in favor of the plain user field which will apply to the custom and default executor cases.

@ssalinas

ssalinas Sep 2, 2016

Member

We already had customExecutorUser for this purpose, but it had been deprecated for a while now. I've officially removed it in favor of the plain user field which will apply to the custom and default executor cases.

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 2, 2016

Member

LGTM aside from comment above

Member

tpetr commented Sep 2, 2016

LGTM aside from comment above

@ssalinas ssalinas added the hs_stable label Sep 2, 2016

@ssalinas ssalinas merged commit 5cc7f19 into master Sep 2, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ssalinas ssalinas deleted the set_user branch Sep 2, 2016

@ssalinas ssalinas modified the milestone: 0.11.0 Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment