Support for setting user in default executor #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssalinas thanks for the addition |
| @@ -381,6 +381,10 @@ private void prepareCustomExecutor(final TaskInfo.Builder bldr, final Singularit | |||
| private void prepareCommand(final TaskInfo.Builder bldr, final SingularityTaskId taskId, final SingularityTaskRequest task, final Protos.Offer offer, final Optional<long[]> ports) { | |||
| CommandInfo.Builder commandBldr = CommandInfo.newBuilder(); | |||
|
|
|||
| if (task.getDeploy().getUser().isPresent()) { | |||
| commandBldr.setUser(task.getDeploy().getUser().get()); | |||
There was a problem hiding this comment.
Can we add this corresponding change to prepareCustomExecutor() too? I can see some utility in being able to control what user the custom executor is launched as.
There was a problem hiding this comment.
We already had customExecutorUser for this purpose, but it had been deprecated for a while now. I've officially removed it in favor of the plain user field which will apply to the custom and default executor cases.
|
LGTM aside from comment above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #1261