Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting user in default executor #1262

Merged
merged 6 commits into from Sep 2, 2016
Merged

Support for setting user in default executor #1262

merged 6 commits into from Sep 2, 2016

Conversation

@ssalinas
Copy link
Member

ssalinas commented Sep 1, 2016

/fixes #1261

ssalinas added 2 commits Sep 1, 2016
@kchaliki
Copy link
Contributor

kchaliki commented Sep 1, 2016

@ssalinas thanks for the addition

@ssalinas ssalinas added the hs_qa label Sep 1, 2016
@@ -381,6 +381,10 @@ private void prepareCustomExecutor(final TaskInfo.Builder bldr, final Singularit
private void prepareCommand(final TaskInfo.Builder bldr, final SingularityTaskId taskId, final SingularityTaskRequest task, final Protos.Offer offer, final Optional<long[]> ports) {
CommandInfo.Builder commandBldr = CommandInfo.newBuilder();

if (task.getDeploy().getUser().isPresent()) {
commandBldr.setUser(task.getDeploy().getUser().get());

This comment has been minimized.

Copy link
@tpetr

tpetr Sep 2, 2016

Member

Can we add this corresponding change to prepareCustomExecutor() too? I can see some utility in being able to control what user the custom executor is launched as.

This comment has been minimized.

Copy link
@ssalinas

ssalinas Sep 2, 2016

Author Member

We already had customExecutorUser for this purpose, but it had been deprecated for a while now. I've officially removed it in favor of the plain user field which will apply to the custom and default executor cases.

@tpetr
Copy link
Member

tpetr commented Sep 2, 2016

LGTM aside from comment above

@ssalinas ssalinas added the hs_stable label Sep 2, 2016
@ssalinas ssalinas merged commit 5cc7f19 into master Sep 2, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ssalinas ssalinas deleted the set_user branch Sep 2, 2016
@ssalinas ssalinas modified the milestone: 0.11.0 Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.