New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slave-extras.md #1265

Merged
merged 1 commit into from Sep 2, 2016

Conversation

Projects
None yet
2 participants
@kchaliki
Contributor

kchaliki commented Sep 2, 2016

I was following this and found that without the quote I get a YAML parsing error in Jackson - this makes it go away but to be honest I have not confirmed it actually works.

14:06:02.743 [main] ERROR c.h.s.e.SingularityExecutorRunner - Finished after 00:01.150 with error
com.google.inject.CreationException: Unable to create injector, see the following errors:

  1. Error in custom provider, while scanning for the next token
    found character % '%' that cannot start any token. (Do not use % for indentation)
    in 'reader', line 14, column 23:
    s3UploaderKeyPattern: %requestId/%Y/%m/%taskId_%index- ...
    ^
@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Sep 2, 2016

Member

You're right, that needs to be wrapped in quotes. Thanks!

Member

tpetr commented Sep 2, 2016

You're right, that needs to be wrapped in quotes. Thanks!

@tpetr tpetr merged commit 1dd4ab7 into HubSpot:master Sep 2, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@tpetr tpetr added this to the 0.11.0 milestone Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment