Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure quotes and new lines are escaped in echo #1332

Merged
merged 1 commit into from Nov 9, 2016
Merged

Conversation

@ssalinas
Copy link
Member

ssalinas commented Oct 31, 2016

So, we had previously made this a bit more resilient to weird new lines in environment variables not being loaded properly in docker by adding them to command line args instead. But, with the right order or quotes/newlines/etc, we can still run into issues at the echo statement before the actual command is executed. This adds escaping for the double quotes as well as calling echo -e so that the escaped characters are expanded properly when printed.

@ssalinas ssalinas added the hs_staging label Oct 31, 2016
@ssalinas ssalinas force-pushed the docker_run_script branch from e7edce4 to 17903b5 Nov 1, 2016
@ssalinas ssalinas added the hs_qa label Nov 1, 2016
@ssalinas ssalinas modified the milestone: 0.12.0 Nov 2, 2016
@ssalinas ssalinas force-pushed the docker_run_script branch from 4153cb1 to 5cc113b Nov 2, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Nov 2, 2016

@tpetr , renamed the helper to be more descriptive here

@ssalinas ssalinas modified the milestones: 0.12.0, 0.13.0 Nov 4, 2016
@tpetr

This comment has been minimized.

Copy link
Member

tpetr commented on 5cc113b Nov 4, 2016

🚢

@ssalinas ssalinas added the hs_stable label Nov 4, 2016
@ssalinas ssalinas merged commit f57d9af into master Nov 9, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the docker_run_script branch Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.