Ensure quotes and new lines are escaped in echo #1332

Merged
merged 1 commit into from Nov 9, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Oct 31, 2016

So, we had previously made this a bit more resilient to weird new lines in environment variables not being loaded properly in docker by adding them to command line args instead. But, with the right order or quotes/newlines/etc, we can still run into issues at the echo statement before the actual command is executed. This adds escaping for the double quotes as well as calling echo -e so that the escaped characters are expanded properly when printed.

@ssalinas ssalinas modified the milestone: 0.12.0 Nov 2, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Nov 2, 2016

Member

@tpetr , renamed the helper to be more descriptive here

Member

ssalinas commented Nov 2, 2016

@tpetr , renamed the helper to be more descriptive here

@ssalinas ssalinas modified the milestones: 0.12.0, 0.13.0 Nov 4, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Nov 4, 2016

Member

🚢

Member

tpetr commented on 5cc113b Nov 4, 2016

🚢

@ssalinas ssalinas added the hs_stable label Nov 4, 2016

@ssalinas ssalinas merged commit f57d9af into master Nov 9, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the docker_run_script branch Nov 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment