Ensure quotes and new lines are escaped in echo#1332
Merged
Conversation
ssalinas
force-pushed
the
docker_run_script
branch
from
e7edce4 to
17903b5
Compare
ssalinas
force-pushed
the
docker_run_script
branch
from
4153cb1 to
5cc113b
Compare
Contributor
Author
|
@tpetr , renamed the helper to be more descriptive here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, we had previously made this a bit more resilient to weird new lines in environment variables not being loaded properly in docker by adding them to command line args instead. But, with the right order or quotes/newlines/etc, we can still run into issues at the
echostatement before the actual command is executed. This adds escaping for the double quotes as well as callingecho -eso that the escaped characters are expanded properly when printed.