Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSanitize file data before parsing with Jackson #1334
Conversation
jhaber
added some commits
Nov 1, 2016
ssalinas
modified the milestone:
0.12.0
Nov 2, 2016
tpetr
added some commits
Nov 2, 2016
tpetr
referenced this pull request
Nov 2, 2016
Merged
replace instead of ignore so that we can update the offset #1335
ssalinas
modified the milestones:
0.12.0,
0.13.0
Nov 4, 2016
tpetr
added some commits
Nov 21, 2016
tpetr
added
the
hs_staging
label
Nov 21, 2016
ssalinas
modified the milestones:
0.13.0,
0.14.0
Dec 8, 2016
ssalinas
added
the
hs_qa
label
Dec 13, 2016
tpetr
added
the
hs_stable
label
Jan 9, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
|
ssalinas
merged commit dc2c4de
into
master
Feb 10, 2017
ssalinas
deleted the
invalid-utf8
branch
Feb 10, 2017
ssalinas
removed
hs_qa
hs_stable
hs_staging
labels
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jhaber commentedNov 1, 2016
This takes the raw response from Mesos and decodes it with a UTF8 decoder that ignores invalid characters before passing the sanitized data to Jackson for parsing (which should now always succeed). Since these responses can be non-trivial in size I tried to avoid extra allocations as much as possible (the
Responseclass exposes the data as aByteBufferwhich gets converted to aCharBufferwhich backs theReaderpassed to Jackson).@tpetr @ssalinas