Skip to content

/ Singularity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize file data before parsing with Jackson #1334

Merged
merged 7 commits into from Feb 10, 2017
Merged

Sanitize file data before parsing with Jackson #1334

merged 7 commits into from Feb 10, 2017

Conversation

@jhaber
Copy link
Member

jhaber commented Nov 1, 2016

This takes the raw response from Mesos and decodes it with a UTF8 decoder that ignores invalid characters before passing the sanitized data to Jackson for parsing (which should now always succeed). Since these responses can be non-trivial in size I tried to avoid extra allocations as much as possible (the Response class exposes the data as a ByteBuffer which gets converted to a CharBuffer which backs the Reader passed to Jackson).

@tpetr @ssalinas
jhaber added 2 commits Nov 1, 2016
@jhaber
Sanitize file data before parsing with Jackson
Loading status checks…
71844e7
@jhaber
Make the test input less opaque
Loading status checks…
cfc6e3b
@ssalinas ssalinas modified the milestone: 0.12.0 Nov 2, 2016
tpetr added 3 commits Nov 2, 2016
@tpetr
replace instead of ignore so that we can update the offset
Loading status checks…
c3c7f6a
@tpetr
forgot a const
Loading status checks…
cf5ad5b
@tpetr
update comments
Loading status checks…
2d92022
@tpetr tpetr mentioned this pull request Nov 2, 2016
Merged
@ssalinas ssalinas modified the milestones: 0.12.0, 0.13.0 Nov 4, 2016
tpetr added 2 commits Nov 21, 2016
@tpetr
Merge pull request #1335 from HubSpot/invalid-utf8-2
Loading status checks…
dfd0835 
replace instead of ignore so that we can update the offset
@tpetr
use replaceWith()
Loading status checks…
f9d61be
@tpetr tpetr added the hs_staging label Nov 21, 2016
@ssalinas ssalinas modified the milestones: 0.13.0, 0.14.0 Dec 8, 2016
@ssalinas ssalinas added the hs_qa label Dec 13, 2016
@tpetr tpetr added the hs_stable label Jan 9, 2017
@ssalinas

This comment has been minimized.

Sign in to view
Copy link
Member

ssalinas commented on 71844e7 Jan 9, 2017

🚢
@ssalinas ssalinas merged commit dc2c4de into master Feb 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the invalid-utf8 branch Feb 10, 2017
@ssalinas ssalinas removed hs_qa labels Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jhaber @ssalinas @tpetr
You can’t perform that action at this time.