Introduce expiring machine state changes#1342
Merged
Merged
Conversation
Contributor
|
So glad you're adding this! Any idea what version this is likely to end up in? |
Contributor
Author
|
Been looking good in our environments so far. Plan is to get it in the next release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generic implementation for all machine state changes (partially in response to #1322). This will allow a machine state change to create an expiring object with a state to revert to and (relevant for decommissions) a param to create immediate cleanups for any tasks left on the decommissioning slave.
Still TODO on this one:
/cc @tpetr @eherot