Introduce expiring machine state changes #1342

Merged
merged 15 commits into from Dec 9, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Nov 7, 2016

A generic implementation for all machine state changes (partially in response to #1322). This will allow a machine state change to create an expiring object with a state to revert to and (relevant for decommissions) a param to create immediate cleanups for any tasks left on the decommissioning slave.

Still TODO on this one:

  • More validation on expiring request
  • Code in expiring action poller to revert state / create cleanups
  • UI to show options for and ability to delete expiring machine state changes
  • TESTS TESTS TESTS!!!

/cc @tpetr @eherot

@ssalinas ssalinas added the hs_staging label Nov 9, 2016

ssalinas added some commits Nov 9, 2016

@ssalinas ssalinas added the hs_qa label Nov 17, 2016

@ssalinas ssalinas modified the milestone: 0.13.0 Nov 18, 2016

ssalinas added some commits Dec 5, 2016

@ssalinas ssalinas added the hs_stable label Dec 6, 2016

@eherot

This comment has been minimized.

Show comment
Hide comment
@eherot

eherot Dec 6, 2016

Contributor

So glad you're adding this! Any idea what version this is likely to end up in?

Contributor

eherot commented Dec 6, 2016

So glad you're adding this! Any idea what version this is likely to end up in?

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Dec 6, 2016

Member

Been looking good in our environments so far. Plan is to get it in the next release

Member

ssalinas commented Dec 6, 2016

Been looking good in our environments so far. Plan is to get it in the next release

@ssalinas ssalinas merged commit 115bbde into master Dec 9, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ssalinas ssalinas deleted the decom_timeout branch Dec 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment