also grab containerId when grabbing directory #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetr
reviewed
Nov 11, 2016
| @@ -27,17 +27,17 @@ | |||
| import io.dropwizard.lifecycle.Managed; | |||
|
|
|||
| @Singleton | |||
| public class SingularityLogSupport implements Managed { | |||
| public class SingularityMesosInfoSupport implements Managed { | |||
There was a problem hiding this comment.
this class name seems a little vague -- perhaps SingularityMesosExecutorInfoSupport ?
|
@tpetr updated the remaining logging statements |
|
Extremely exciting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently already do a call to fetch the directory after a task starts, then save that on the
SingularityTaskHistoryobject returned by the api. This extends that a bit to also grab the container id from the executor info (previously only visible by picking apart chunks of the directory name)./fixes #1204
/cc @pennello