also grab containerId when grabbing directory #1344

Merged
merged 4 commits into from Nov 21, 2016

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Nov 11, 2016

We currently already do a call to fetch the directory after a task starts, then save that on the SingularityTaskHistory object returned by the api. This extends that a bit to also grab the container id from the executor info (previously only visible by picking apart chunks of the directory name).

/fixes #1204
/cc @pennello

@ssalinas ssalinas added the hs_staging label Nov 11, 2016

@tpetr

There's a bunch of log lines that just reference fetching the task directory -- could you update those too?

@@ -27,17 +27,17 @@
import io.dropwizard.lifecycle.Managed;
@Singleton
-public class SingularityLogSupport implements Managed {
+public class SingularityMesosInfoSupport implements Managed {

This comment has been minimized.

@tpetr

tpetr Nov 11, 2016

Member

this class name seems a little vague -- perhaps SingularityMesosExecutorInfoSupport ?

@tpetr

tpetr Nov 11, 2016

Member

this class name seems a little vague -- perhaps SingularityMesosExecutorInfoSupport ?

This comment has been minimized.

@ssalinas

ssalinas Nov 11, 2016

Member

👍 renamed

@ssalinas

ssalinas Nov 11, 2016

Member

👍 renamed

ssalinas added some commits Nov 11, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Nov 11, 2016

Member

@tpetr updated the remaining logging statements

Member

ssalinas commented Nov 11, 2016

@tpetr updated the remaining logging statements

@pennello

This comment has been minimized.

Show comment
Hide comment
@pennello

pennello Nov 11, 2016

Extremely exciting.

Extremely exciting.

@ssalinas ssalinas modified the milestone: 0.13.0 Nov 18, 2016

@ssalinas ssalinas merged commit e361b15 into master Nov 21, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the mesos_container_id branch Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment