Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also grab containerId when grabbing directory #1344

Merged
merged 4 commits into from Nov 21, 2016
Merged

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Nov 11, 2016

We currently already do a call to fetch the directory after a task starts, then save that on the SingularityTaskHistory object returned by the api. This extends that a bit to also grab the container id from the executor info (previously only visible by picking apart chunks of the directory name).

/fixes #1204
/cc @pennello

Copy link
Contributor

@tpetr tpetr left a comment

There's a bunch of log lines that just reference fetching the task directory -- could you update those too?

@@ -27,17 +27,17 @@
import io.dropwizard.lifecycle.Managed;

@Singleton
public class SingularityLogSupport implements Managed {
public class SingularityMesosInfoSupport implements Managed {
Copy link
Contributor

@tpetr tpetr Nov 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class name seems a little vague -- perhaps SingularityMesosExecutorInfoSupport ?

Copy link
Member Author

@ssalinas ssalinas Nov 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 renamed

@ssalinas
Copy link
Member Author

ssalinas commented Nov 11, 2016

@tpetr updated the remaining logging statements

@pennello
Copy link

pennello commented Nov 11, 2016

Extremely exciting.

@ssalinas ssalinas modified the milestone: 0.13.0 Nov 18, 2016
@ssalinas ssalinas merged commit e361b15 into master Nov 21, 2016
1 of 2 checks passed
@ssalinas ssalinas deleted the mesos_container_id branch Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose particular docker-related ID
3 participants