Skip to content

Fix when bounce alert banner is shown #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2016
Merged

Fix when bounce alert banner is shown #1345

merged 2 commits into from
Nov 16, 2016

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Nov 14, 2016

  • Don't show for non-long-running no matter what
  • parens are important in if statements...

In it's previous form, the logic was displaying the banner on the request detail page when any task cleanups of type bounce or incremental bounce were present

@ssalinas ssalinas merged commit f2f7164 into master Nov 16, 2016
@ssalinas ssalinas deleted the bounce_message_fix branch November 16, 2016 19:23
@ssalinas ssalinas modified the milestone: 0.13.0 Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant